Skip to content
/ rector-src Public

[TypeDeclarationDocblocks] Allow override dummy mixed[] SpacingAwareArrayTypeNode array on UsefulArrayTagNodeAnalyzer#7396

Merged
TomasVotruba merged 5 commits intomainfrom
allow-override-dummy-mixed-array
Oct 1, 2025
Merged

[TypeDeclarationDocblocks] Allow override dummy mixed[] SpacingAwareArrayTypeNode array on UsefulArrayTagNodeAnalyzer#7396
TomasVotruba merged 5 commits intomainfrom
allow-override-dummy-mixed-array

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 1, 2025

@TomasVotruba let's improve UsefulArrayTagNodeAnalyzer to allow dummy mixed[] spacing aware array type node, which mostly won't be used as Templated Tag:

    /**
-    * @return mixed[]
+    * @return int[][]
     */

@samsonasik
[TypeDeclarationDocblocks] Allow override dummy mixed[] SpacingAwareA…
9994a58 
…rrayTypeNode array on UsefulArrayTagNodeAnalyzer
@samsonasik
Copy link
Member Author

samsonasik commented Oct 1, 2025

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik samsonasik marked this pull request as draft October 1, 2025 16:23
@samsonasik
Copy link
Member Author

samsonasik commented Oct 1, 2025 •
edited
Loading

Rectify seems cause PHPStan error.

It seems when public method changed based on external call, it cause PHPStan error as different passed data.

@samsonasik
Copy link
Member Author

samsonasik commented Oct 1, 2025 •
edited
Loading

I reverted rectify 17215ca

Then skip public method with mixed[] array docblock on ClassMethodArrayDocblockParamFromLocalCallsRector 641bc81 as the caller can be anything that applicable for mixed[]

@samsonasik samsonasik marked this pull request as ready for review October 1, 2025 16:39
@samsonasik
Copy link
Member Author

samsonasik commented Oct 1, 2025

Fixed 👍

@samsonasik
Copy link
Member Author

samsonasik commented Oct 1, 2025

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

TomasVotruba commented Oct 1, 2025

Very nice, even few improvements in our codebase 👍

@TomasVotruba TomasVotruba merged commit 66c3294 into main Oct 1, 2025
50 checks passed
@TomasVotruba TomasVotruba deleted the allow-override-dummy-mixed-array branch October 1, 2025 17:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba @actions-user